[No QA] Update Manage-Company-Cards.md#83601
[No QA] Update Manage-Company-Cards.md#83601brianlee-expensify wants to merge 2 commits intomainfrom
Conversation
PR Author Checklist
|
docs/articles/expensify-classic/connect-credit-cards/Manage-Company-Cards.md
Outdated
Show resolved
Hide resolved
| 1. Complete the required [Amex forms](https://drive.google.com/file/d/1zqDA_MCk06jk_fWjzx2y0r4gOyAMqKJe/view?usp=sharing). | ||
| 2. Email the forms to American Express. | ||
| 3. Submit the provided production file information to Expensify. | ||
| 3. Once American Express provides you with the feed details, please send them over to concierge@expensify.com. |
There was a problem hiding this comment.
Consistency note: The Mastercard and Visa sections both direct users to submit information via the submission form, but this American Express step directs users to email concierge@expensify.com instead.
If the email address is intentionally the correct channel for AMEX feed details, this is fine -- but it may be worth confirming whether the same Typeform submission link should be used here for consistency, or whether a brief note explaining why AMEX uses a different submission method would help users understand the difference.
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single-line change to step 3 of the American Express commercial card feed setup instructions. The goal is to clarify where users should send their Amex feed information. The addition of the specific email address (concierge@expensify.com) is a meaningful improvement -- the old text ("Submit the provided production file information to Expensify") was vague about both what to submit and how to submit it. However, the new phrasing introduces tone and structure inconsistencies with the rest of the document that should be addressed before merging. Scores Summary
Key FindingsPositive aspects:
Issues that should be addressed:
RecommendationsSuggested rewrite for step 3: This revision:
If the intent is to signal that this step depends on American Express responding first, consider adding a brief note after the step rather than embedding the condition into the step itself. For example: Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Adding someone else to merge |
|
A preview of your ExpensifyHelp changes have been deployed to https://6e26861a.helpdot.pages.dev ⚡️ Updated articles: |
Explanation of Change
provide more clarity on where to send AMEX feed info
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari